On Fri, Feb 3, 2017 at 1:17 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> From: Tony Lindgren <tony@xxxxxxxxxxx>
> Date: Mon, 30 Jan 2017 07:10:31 -0800
> Subject: [PATCH] power: bq24190_charger: Use PM runtime autosuspend
>
> We can get quite a few interrupts when the battery is trickle charging.
> Let's enable PM runtime autosuspend to avoid constantly toggling device
> driver PM runtime state.
>
> Let's use a 600 ms timeout as that's how long the USB chager detection
> might take.
>
> Cc: Liam Breck <kernel@xxxxxxxxxxxxxxxxx>
> Acked-by: Mark Greer <mgreer@xxxxxxxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
> drivers/power/supply/bq24190_charger.c | 155 ++++++++++++++++++++++++---------
> 1 file changed, 113 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
>
> @@ -1430,14 +1475,20 @@ static int bq24190_probe(struct i2c_client *client,
> static int bq24190_remove(struct i2c_client *client)
> {
> struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
> + int error;
>
> - pm_runtime_get_sync(bdi->dev);
> - bq24190_register_reset(bdi);
> - pm_runtime_put_sync(bdi->dev);
> + error = pm_runtime_get_sync(bdi->dev);
> + if (error < 0) {
> + dev_warn(bdi->dev, "pm_runtime_get failed: %i\n", error);
> + pm_runtime_put_noidle(bdi->dev);
> + }
>
> + bq24190_register_reset(bdi);
> bq24190_sysfs_remove_group(bdi);
> power_supply_unregister(bdi->battery);
> power_supply_unregister(bdi->charger);
> + pm_runtime_put_sync(bdi->dev);
> + pm_runtime_dont_use_autosuspend(bdi->dev);
> pm_runtime_disable(bdi->dev);
I think you addressed this, but should the above be
if (!error)
pm_runtime_put_sync(bdi->dev);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
