On Fri, Feb 3, 2017 at 1:17 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> From: Tony Lindgren <tony@xxxxxxxxxxx>
> Date: Mon, 30 Jan 2017 07:10:31 -0800
> Subject: [PATCH] power: bq24190_charger: Use PM runtime autosuspend
>
> We can get quite a few interrupts when the battery is trickle charging.
> Let's enable PM runtime autosuspend to avoid constantly toggling device
> driver PM runtime state.
>
> Let's use a 600 ms timeout as that's how long the USB chager detection
> might take.
>
> Cc: Liam Breck <kernel@xxxxxxxxxxxxxxxxx>
> Acked-by: Mark Greer <mgreer@xxxxxxxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
Acked-by: Liam Breck <kernel@xxxxxxxxxxxxxxxxx>
> @@ -1480,10 +1531,20 @@ static int bq24190_pm_suspend(struct device *dev)
> {
> struct i2c_client *client = to_i2c_client(dev);
> struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
> + int error;
> +
> + error = pm_runtime_get_sync(bdi->dev);
> + if (error < 0) {
> + dev_warn(bdi->dev, "pm_runtime_get failed: %i\n", error);
> + pm_runtime_put_noidle(bdi->dev);
> + }
>
> - pm_runtime_get_sync(bdi->dev);
> bq24190_register_reset(bdi);
> - pm_runtime_put_sync(bdi->dev);
> +
> + if (!error) {
> + pm_runtime_mark_last_busy(bdi->dev);
> + pm_runtime_put_autosuspend(bdi->dev);
> + }
>
> return 0;
> }
> @@ -1492,15 +1553,25 @@ static int bq24190_pm_resume(struct device *dev)
> {
> struct i2c_client *client = to_i2c_client(dev);
> struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
> + int error;
>
> bdi->f_reg = 0;
> bdi->ss_reg = BQ24190_REG_SS_VBUS_STAT_MASK; /* impossible state */
>
> - pm_runtime_get_sync(bdi->dev);
> + error = pm_runtime_get_sync(bdi->dev);
> + if (error < 0) {
> + pm_runtime_put_noidle(bdi->dev);
> + dev_warn(bdi->dev, "pm_runtime_get failed: %i\n", error);
> + }
Last nitpick: call put_noidle after dev_warn, as in suspend :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
