Hi Ladislav, On Monday 05 Dec 2016 10:36:49 Ladislav Michl wrote: > On Mon, Dec 05, 2016 at 10:46:43AM +0200, Laurent Pinchart wrote: > > On Monday 05 Dec 2016 09:22:10 Ladislav Michl wrote: > [snip] > > >> Table 36 list two options with 26MHz clocks: m=443, n=11 and m=480, n=12 > >> with a statement: "The choice between these two options with a 26 MHz > >> input should be based on characterization on the end system." > >> > >> Shall we care about that? > > > > I'd like to, but at the moment I don't see how. Proposals are welcome :-) > > I > > One of proposals raised earlier was DT property, but that idea was scratched > later. > > > don't think addressing that issue should be a blocker to get this patch > > merged though. > > Of course not. I'd like to even see it in stable ;-) > > [snip] > > > I had tried that, but I find the code less readable :-S > > Oh... Please reconsider (I really do not like that extra test and extra > assignment to local variables (also I had 'precomputed' as mixed definition, > but Tero did not quite like that)) :-) I've tested both versions with gcc 4.7.3 [1] and 4.8.5 [2]. With 4.7.3 my version is 4 bytes longer, and with 4.8.5 it's 4 bytes shorter. Interestingly enough the "break + test after loop" pattern doesn't make a difference, it's only the intermediate variable that results in changes to the generated code. [1] arm-linux-gnueabihf-gcc (crosstool-NG linaro-1.13.1-4.7-2013.02-01-20130221 - Linaro GCC 2013.02) 4.7.3 20130205 (prerelease) [2] arm-buildroot-linux-uclibcgnueabihf-gcc.br_real (Buildroot 2016.08-dirty) 4.8.5 > Also, checked if the same values are > written to clk as with my patch, so here's my: > Tested-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx> -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
