On Wed, Nov 23, 2016 at 9:15 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > On 11/23/2016 12:08 PM, Yegor Yefremov wrote: >> On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: >>> On 11/23/2016 06:38 AM, yegorslists@xxxxxxxxxxxxxx wrote: >>>> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx> >>>> >>>> Add the ability to query and set Energy Efficient Ethernet parameters >>>> via ethtool for applicable devices. >>> >>> Are you sure this is enough to actually enable EEE? I don't see where >>> phy_init_eee() is called here, nor is the cpsw Ethernet controller part >>> configured to enable/disable EEE. EEE is not just a PHY thing, it >>> usually also needs to be configured properly at the Ethernet MAC/switch >>> level as well. >>> >>> Just curious here. >> >> I'm sure I want to disable EEE :-) So I need this patch in order to >> check and disable EEE advertising. > > OK, so you need this to disable EEE advertisement, which is great, but > this also allows you to enable EEE, is it enough to just advertise EEE > with your link partner for cpsw to work correctly? Just wondering, since > your commit message is more than short. I've sent v3 with a little bit more info. Basically this is needed for this kind of issues [1] As for enabling advertising and correct working of cpsw do you mean it would be better to disable EEE in any PHY on cpsw initialization as long as cpsw doesn't provide support for EEE? We observe some strange behavior with our gigabit PHYs and a link partner in a EEE-capable unmanaged NetGear switch. Disabling advertising seems to help. Though we're still investigating the issue. [1] http://www.spinics.net/lists/netdev/msg405396.html Yegor -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
