Hi Rami, On Wed, Nov 23, 2016 at 3:31 PM, Rami Rosen <roszenrami@xxxxxxxxx> wrote: > Hi, Yegor, > > Minor comment: these methods should be static. > > +int cpsw_get_eee(struct net_device *ndev, struct ethtool_eee *edata) > +{ > ... > ... > +int cpsw_set_eee(struct net_device *ndev, struct ethtool_eee *edata) > ... ACK. Fixed in v2. Thanks. Yegor -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html