* Steve Sakoman <sakoman@xxxxxxxxx> [090430 08:10]:
> On Thu, Apr 30, 2009 at 3:16 AM, Mark Brown <broonie@xxxxxxxxxxxxx> wrote:
> > On Thu, Apr 30, 2009 at 12:31:47PM +0300, Grazvydas Ignotas wrote:
> >> On Wed, Apr 29, 2009 at 7:03 PM, Steve Sakoman <sakoman@xxxxxxxxx> wrote:
> >
> >> > set_machine_constraints: invalid 'VUSB1V5' voltage constraints
> >
> >> I get the same on pandora, although it continues booting fine after
> >> that. Maybe regulator folks will comment about regulator errors.
> >
> > I suspect this may be due to the buggy defaults that are provided when
> > no voltage constraints are given for a fixed voltage regulator. There's
> > a patch on its way to mainline fixing this:
>
> Thanks Mark! This patch does indeed fix the regulator issues, and the
> system seems to operate normally once again.
Great. Looks like -rc4 is out, so I'll update our omap tree to that today,
and we'll get this patch in.
Tony
> The platform data messages still appear, but a quick look at the code
> that generates them shows that we are at the start of a transition in
> how platform data is handled (both old and new style are handled at
> the moment). Seems we will have a bit of work to do to adapt.
>
> i2c_omap i2c_omap.1: bus 1 rev3.12 at 2600 kHz
> twl4030: PIH (irq 7) chaining IRQs 368..375
> twl4030: power (irq 373) chaining IRQs 376..383
> twl4030_gpio: use which platform_data?
> twl4030: gpio (irq 368) chaining IRQs 384..401
> mmci-omap-hs.0: use which platform_data?
> mmci-omap-hs.1: use which platform_data?
> twl4030_usb: use which platform_data?
> twl4030_reg.6: use which platform_data?
> regulator: VMMC1: 1850 <--> 3150 mV normal standby
> twl4030_reg.17: use which platform_data?
> regulator: VUSB1V5: 1500 mV normal standby
> twl4030_reg.18: use which platform_data?
> regulator: VUSB1V8: 1800 mV normal standby
> twl4030_reg.19: use which platform_data?
> regulator: VUSB3V1: 3100 mV normal standby
>
>
> Steve
>
>
> >
> > commit 14d32bb077f7cc6f78bd012e5b1489899dddf749
> > Author: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > Date: Tue Apr 28 11:09:38 2009 +0100
> >
> > regulator: Fix default constraints for fixed voltage regulators
> >
> > Default voltage constraints were being provided for fixed voltage
> > regulator where board constraints were not provided but these constraints
> > used INT_MIN as the default minimum voltage which is not a valid value
> > since it is less than zero. Use 1uV instead.
> >
> > Also set the default values we set in the constraints themselves since
> > otherwise the max_uV constraint we determine will not be stored in the
> > actual constraint strucutre and will therefore not be used.
> >
> > Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>
> >
> > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> > index 2f14c16..98c3a74 100644
> > --- a/drivers/regulator/core.c
> > +++ b/drivers/regulator/core.c
> > @@ -703,10 +703,13 @@ static int set_machine_constraints(struct regulator_dev *rdev,
> > int cmin = constraints->min_uV;
> > int cmax = constraints->max_uV;
> >
> > - /* it's safe to autoconfigure fixed-voltage supplies */
> > + /* it's safe to autoconfigure fixed-voltage supplies
> > + and the constraints are used by list_voltage. */
> > if (count == 1 && !cmin) {
> > - cmin = INT_MIN;
> > + cmin = 1;
> > cmax = INT_MAX;
> > + constraints->min_uV = cmin;
> > + constraints->max_uV = cmax;
> > }
> >
> > /* voltage constraints are optional */
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
