Re: [PATCH 2/2] mfd: twl4030-audio: make module DT only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nicolae,

[auto build test ERROR on asoc/for-next]
[also build test ERROR on v4.9-rc5 next-20161115]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nicolae-Rosia/ASoC-omap-twl4030-rework-probing-for-device-tree-only/20161115-165843
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-randconfig-i0-201646 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

>> drivers/input/misc/twl4030-vibra.c:181:17: warning: 'struct twl4030_vibra_data' declared inside parameter list [enabled by default]
             struct device_node *node)
                    ^
>> drivers/input/misc/twl4030-vibra.c:181:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
   drivers/input/misc/twl4030-vibra.c: In function 'twl4030_vibra_check_coexist':
>> drivers/input/misc/twl4030-vibra.c:183:20: error: dereferencing pointer to incomplete type
     if (pdata && pdata->coexist)
                       ^
   drivers/input/misc/twl4030-vibra.c: In function 'twl4030_vibra_probe':
>> drivers/input/misc/twl4030-vibra.c:212:2: warning: passing argument 1 of 'twl4030_vibra_check_coexist' from incompatible pointer type [enabled by default]
     info->coexist = twl4030_vibra_check_coexist(pdata, twl4030_core_node);
     ^
   drivers/input/misc/twl4030-vibra.c:180:13: note: expected 'struct twl4030_vibra_data *' but argument is of type 'struct twl4030_vibra_data *'
    static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
                ^

vim +181 drivers/input/misc/twl4030-vibra.c

3dd1b3949 Jari Vanhala   2010-03-09  175  }
3dd1b3949 Jari Vanhala   2010-03-09  176  
3dd1b3949 Jari Vanhala   2010-03-09  177  static SIMPLE_DEV_PM_OPS(twl4030_vibra_pm_ops,
3dd1b3949 Jari Vanhala   2010-03-09  178  			 twl4030_vibra_suspend, twl4030_vibra_resume);
3dd1b3949 Jari Vanhala   2010-03-09  179  
64b9e4d80 Peter Ujfalusi 2012-09-10  180  static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
64b9e4d80 Peter Ujfalusi 2012-09-10 @181  			      struct device_node *node)
64b9e4d80 Peter Ujfalusi 2012-09-10  182  {
64b9e4d80 Peter Ujfalusi 2012-09-10 @183  	if (pdata && pdata->coexist)
64b9e4d80 Peter Ujfalusi 2012-09-10  184  		return true;
64b9e4d80 Peter Ujfalusi 2012-09-10  185  
e661d0a04 Marek Belisko  2015-07-29  186  	node = of_find_node_by_name(node, "codec");
e661d0a04 Marek Belisko  2015-07-29  187  	if (node) {
a9e1d3c04 Libo Chen      2014-01-03  188  		of_node_put(node);
64b9e4d80 Peter Ujfalusi 2012-09-10  189  		return true;
a9e1d3c04 Libo Chen      2014-01-03  190  	}
64b9e4d80 Peter Ujfalusi 2012-09-10  191  
64b9e4d80 Peter Ujfalusi 2012-09-10  192  	return false;
64b9e4d80 Peter Ujfalusi 2012-09-10  193  }
64b9e4d80 Peter Ujfalusi 2012-09-10  194  
5298cc4cc Bill Pemberton 2012-11-23  195  static int twl4030_vibra_probe(struct platform_device *pdev)
3dd1b3949 Jari Vanhala   2010-03-09  196  {
c838cb3d4 Jingoo Han     2013-12-05  197  	struct twl4030_vibra_data *pdata = dev_get_platdata(&pdev->dev);
64b9e4d80 Peter Ujfalusi 2012-09-10  198  	struct device_node *twl4030_core_node = pdev->dev.parent->of_node;
3dd1b3949 Jari Vanhala   2010-03-09  199  	struct vibra_info *info;
3dd1b3949 Jari Vanhala   2010-03-09  200  	int ret;
3dd1b3949 Jari Vanhala   2010-03-09  201  
64b9e4d80 Peter Ujfalusi 2012-09-10  202  	if (!pdata && !twl4030_core_node) {
3dd1b3949 Jari Vanhala   2010-03-09  203  		dev_dbg(&pdev->dev, "platform_data not available\n");
3dd1b3949 Jari Vanhala   2010-03-09  204  		return -EINVAL;
3dd1b3949 Jari Vanhala   2010-03-09  205  	}
3dd1b3949 Jari Vanhala   2010-03-09  206  
c3ead16e7 Peter Ujfalusi 2013-01-11  207  	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
3dd1b3949 Jari Vanhala   2010-03-09  208  	if (!info)
3dd1b3949 Jari Vanhala   2010-03-09  209  		return -ENOMEM;
3dd1b3949 Jari Vanhala   2010-03-09  210  
3dd1b3949 Jari Vanhala   2010-03-09  211  	info->dev = &pdev->dev;
64b9e4d80 Peter Ujfalusi 2012-09-10 @212  	info->coexist = twl4030_vibra_check_coexist(pdata, twl4030_core_node);
3dd1b3949 Jari Vanhala   2010-03-09  213  	INIT_WORK(&info->play_work, vibra_play_work);
3dd1b3949 Jari Vanhala   2010-03-09  214  
c3ead16e7 Peter Ujfalusi 2013-01-11  215  	info->input_dev = devm_input_allocate_device(&pdev->dev);

:::::: The code at line 181 was first introduced by commit
:::::: 64b9e4d803b154a78a2e76bd466bb32ad6f383de input: twl4030-vibra: Support for DT booted kernel

:::::: TO: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
:::::: CC: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux