Re: [PATCH] OMAPDSS: Kconfig: Add HDMI for OMAP4 and OMAP5 dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/04/2016 01:17 PM, Adam Ford wrote:
[...]
Sorry, I didn't know how to do that. .  Thank you for showing me how
to do that.  I will CC everyone in the future.  Until this point, I
have only ever submitted patches for a couple board device trees, so
there was no maintainer.


No issues, we all learn.. it is easier when you run ./scripts/get_maintainer script on patches to get the list.

[...]

 config OMAP5_DSS_HDMI
        bool "HDMI support for OMAP5"
+       depends on SOC_OMAP5


Did you miss SOC_DRA7XX?

I am not familiar with DRA7, is that fall under the OMAP5?  I only
added the dependencies because I disabled the OMAP4,5 and DRA7 stuff
and noticed these options were still compiling in.

DRA7 is a different SoC, but many components tend to be reused from OMAP5.


Is something like the following appropriate?

+       depends on SOC_OMAP5 || SOC_DRA7XX

If so, I'll update the patch tonight and resubmit for everyone to review.

Here is how I noticed it:
$ git grep compatible drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c
drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: { .compatible = "ti,omap5-hdmi", }, drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: { .compatible = "ti,dra7-hdmi", },

Tomi can comment if that is the right thing to do..

[...]

--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux