Re: Potential double spin_lock_irqsave BUG in Linux 4.7's drivers/net/ethernet/ti/davinci_cpdma.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26.09.16 11:35, Iago Abal wrote:
Hi all,

Using a static bug finder (EBA - https://github.com/models-team/eba) I may
have found a double spin_lock_irqsave in Linux 4.7's
drivers/net/ethernet/ti/davinci_cpdma.c. The forward trace is as follows:

1. Starting un function `cpdma_clr_destroy' (defined in line 443);
2. the lock is taken first at 451:

       spin_lock_irqsave(&ctlr->lock, flags);

3. if (ctlr->state != CPDMA_STATE_IDLE) evaluates to `true' at 452;
4. we then call function `cpdma_ctlr_stop' passing `ctrl` to it, at 453;
6. finally, the lock is taken a second time at 346:

       spin_lock_irqsave(&ctlr->lock, flags);

If that's a bug then I am willing to help with a patch.

Thank you for your time,

Iago


I think  it's solved already
fccd5ba net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()


--
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux