On Wed, Sep 14, 2016 at 04:02:25PM +0300, Grygorii Strashko wrote: > The current implementation CPTS initialization and deinitialization > (represented by cpts_register/unregister()) is pretty entangled and > has some issues, like: > - ptp clock registered before spinlock, which is protecting it, and > before timecounter and cyclecounter initialization; > - CPTS ref_clk requested using devm API while cpts_register() is > called from .ndo_open(), as result additional checks required; > - CPTS ref_clk is prepared, but never unprepared; > - CPTS is not disabled even when unregistered.. This list of four items is a clear sign that this one patch should be broken into a series of four. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html