Re: [PATCH][UPDATED] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 17, 2009 at 8:45 PM, Ramirez Luna, Omar <x00omar@xxxxxx> wrote:
> Hi,
>
> Artem Bityutskiy wrote:
>>
>>I'm sorry. Authors of the code may delete this e-mail.
>>More flame and suggestions.
>>
>
> Thanks for your suggestions; it is true that bridge code has been out for a while, almost a year I think, and we are still trying to enhance it and clean it up along the way, although it may seem we have stalled on the task.
>
> Please friendly flame about other parts of bridge code too ;) as we can take very good points of your's/everyone's comments and try to put in better shape the driver to be pushed into mainline (as this has been the goal all the time). Thanks for the time reviewing the code.

The purpose of this mailing list is not to make friends, it's to
develop good quality software. You might not like this "unfriendly"
approach, but it is the style of many linux maintainers, and I believe
for good reason.

When you think the code is ugly, and you want the message to get
across effectively you say it's ugly. This might hurt some people
sensitivities but it's the truth, and sugar-coating will not make the
code any less uglier.

While there has been good progress in the bridgedriver, it is still
*very* far away from meeting mainline standards and this makes many
people uneasy, including me.

Artem complains will need to be addressed one way or another. So, can
we have at least have a TODO file with these complaints?

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux