On 09/14/2016 11:32 PM, Richard Cochran wrote: > On Wed, Sep 14, 2016 at 11:10:48PM +0300, Grygorii Strashko wrote: >> On 09/14/2016 04:52 PM, Richard Cochran wrote: >>> On Wed, Sep 14, 2016 at 04:02:25PM +0300, Grygorii Strashko wrote: > >>>> - if (!cpts->rx_enable) >>>> + if (!cpts || !cpts->rx_enable) >>>> return; > >> Ok. I can't say I'd like all this checks, but there are internal requirement >> to allow CPTS to be disabled though DT on KS2 (even if built in). >> I'd try to clarify and return back here. >> >> But It'll be good to know your position - acceptable/can be discussed/completely unacceptable? > > Look at that code snippet. We already test for @cpts->rx_enable. If > you want to disable cpts at run time, just avoid setting that field. > There is no need for any new tests or return codes. > The problem is that if cpts not initialized than pinter on cpts (in consumer/parent driver - NETCP) will be NULL. So, rx_enable will be unaccessible and cause crash :( -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
