Re: [PATCH] memory: omap-gpmc: use devm_gpiochip_add_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/08/16 16:39, Linus Walleij wrote:
> On Mon, Aug 8, 2016 at 12:37 PM, Roger Quadros <rogerq@xxxxxx> wrote:
> 
>> Looks like we need to patch this with
>>
>> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
>> index 68f0a92..dff7b9e 100644
>> --- a/drivers/memory/omap-gpmc.c
>> +++ b/drivers/memory/omap-gpmc.c
>> @@ -2359,7 +2359,7 @@ static int gpmc_probe(struct platform_device *pdev)
>>         rc = gpmc_setup_irq(gpmc);
>>         if (rc) {
>>                 dev_err(gpmc->dev, "gpmc_setup_irq failed\n");
>> -               goto setup_irq_failed;
>> +               goto gpio_init_failed;
>>         }
>>
>>         rc = gpmc_probe_dt_children(pdev);
>> @@ -2372,8 +2372,6 @@ static int gpmc_probe(struct platform_device *pdev)
>>
>>  dt_children_failed:
>>         gpmc_free_irq(gpmc);
>> -setup_irq_failed:
>> -       gpmc_gpio_exit(gpmc);
> 
> Thanks Roger, sorry about my screwups :(
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 

Thanks. I'll merge this change into your original patch.

regards,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux