On Thu, 4 Aug 2016 18:31:29 +0200 Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote: > Hi, > > On Thu, 4 Aug 2016 07:29:19 -0700 > Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > Hi, > > > > * H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> [160803 10:07]: > > > All this prevents detection of cable plugin-events and VBUS > > > measurement and setting OTG_EN before charging is attempted. > > > > So I gave this patch a try but it now blocks all deeper SoC idle > > states as the PHY stays active. I think the real fix is to make > > sure the charger behaves independent of the USB PHY state. So > > probably this needs to be fixed in phy-twl4030-usb.c and > > twl4030_charger.c instead. Now it sounds like we're also shutting > > down the charger with the USB PHY. > > > Then there is another power management issue. The patch is not about > fixing every pm issue in musb. That is not only about charging, it is > about enabling/disabling() the phy unbalanced: > Again what happens here without the patch: > > musb will be initialized: > omap2430_musb_disable() > calls phy_power_off(), phy will be disabled, > phy->power_count goes to -1. > sorry mixed something up. Nothing happens here, so the previous state of the phy remains. It would be disabled by the generic phy layer in drivers/phy/phy-core.c > gadget driver is loaded. > musb_start() is called > omap2430_musb_enable() is called > calls phy_power_on(), > phy->power_count goes to 0, > phy is not powered on because power_count != 1 > -> no gadget working, no charging. > ... if not configured by u-boot before. USB gadget might work when initialized earlier in the boot process (u-boot/x-loader/mlo ...) and phy-twl4030 cannot do anything about it besides if we change drivers/phy/phy-core.c Regards, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
