Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/26/2016 03:57 AM, David Miller wrote:
From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Date: Mon, 25 Jul 2016 11:54:45 +0200

Such a big dump of register values is hardly useful on a production
system.

Another downside of the now removed functions is that calling
emac_dump_regs resulted in at least 87 calls to dev_info while holding a
spinlock and having irqs off which is a big source of latency.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Applied.


:( To be honest I was really enjoyed using cpdma_ctlr_dump()
for debug purposed during the past few weeks in cpsw where I've added calls to this func manually. And I even thinking about adding debug_fs entry for the same :(

Pretty fast merge :(


--
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux