[PATCH 0/4] ARM: OMAP2+: Fix AM335x RTC External Abort

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
With next-20160711 there is an external abort during boot on am335x
platforms from the RTC which is caused by commit 183e2077d007 ("ARM:
AM33xx: fix module_wait_ready without clkctrl register"), log is here [1].
The RTC hwmod is unique in that it has a clkctrl_offs of 0 which is
invalid normally, all other hwmods have non-zero offsets. Because of this,
we need to flag the hwmod so 0 actually gets used for the offset
instead of the just returning 0 and doing nothing.

This series adds a HWMOD_OMAP4_ZERO_CLKCTRL_OFFSET flag and moves the check
for validity of the clkctrl_offs value to the omap_hwmod code so that we are
able to check both the flag and clkctrl_offs values. This code is shared by
all OMAP4+ platforms but shoudl have no affect for anything but RTC on
am335x but still boot tested on the following platforms:

AM335x GP EVM:		Pass http://pastebin.ubuntu.com/19186160/
Beaglebone Black:	Pass http://pastebin.ubuntu.com/19186862/
AM437x GP EVM:		Pass http://pastebin.ubuntu.com/19186555/
OMAP4 Panda ES:		Pass http://pastebin.ubuntu.com/19186711/
OMAP5 uEVM:		Pass http://pastebin.ubuntu.com/19186925/

Regards,
Dave

[1] https://storage.kernelci.org/next/next-20160711/arm-omap2plus_defconfig/lab-baylibre-seattle/boot-am335x-boneblack.html

Dave Gerlach (4):
  ARM: OMAP4+: hwmod: Add hwmod flag for HWMOD_OMAP4_ZERO_CLKCTRL_OFFSET
  ARM: OMAP2+: AM33XX: Add HWMOD_OMAP4_ZERO_CLKCTRL_OFFSET flag to rtc
    hwmod
  ARM: OMAP4+: Have _omap4_wait_target_* check for valid clkctrl_offs
  ARM: OMAP4+: CM: Remove redundant checks for clkctrl_offs of zero

 arch/arm/mach-omap2/cm33xx.c                            | 6 ------
 arch/arm/mach-omap2/cminst44xx.c                        | 6 ------
 arch/arm/mach-omap2/omap_hwmod.c                        | 8 ++++++++
 arch/arm/mach-omap2/omap_hwmod.h                        | 4 ++++
 arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 2 ++
 5 files changed, 14 insertions(+), 12 deletions(-)

-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux