Hi Roger, Many thanks for the feedback. Do I need to do something else concerning this patch? Br, Sébastien ----------------------------- Eaton Industries (France) S.A.S ~ Siège social: 110 Rue Blaise Pascal, Immeuble Le Viséo - Bâtiment A Innovallée, 38330, Montbonnot-St.-Martin, France ~ Lieu d'enregistrement au registre du commerce: Grenoble ~ Numéro d'enregistrement: 509 653 176 ~ Capital social souscrit et liberé:€ 16215441 ~ Numéro de TVA: FR47509653176 ----------------------------- -----Message d'origine----- De : Roger Quadros [mailto:rogerq@xxxxxx] Envoyé : mercredi 15 juin 2016 16:03 À : Ocquidant, Sebastien; tony@xxxxxxxxxxx Cc : linux-omap@xxxxxxxxxxxxxxx Objet : Re: [PATCH] Fix omap gpmc OEEXTRADELAY and WEEXTRADELAY timing Sébastien, On 15/06/16 16:23, SebastienOcquidant@xxxxxxxxx wrote: > Dear Roger, > > I've apply your recommendation. Below is the patch. > I cannot use git-send-email as I am using a VM to run linux and my > organization do not allow me to send email from it :o( > > Br, > > Sébastien > > --- Patch starts below --- > > From 5e5d5194eeb4c74845a89138d6145780baa9fd99 Mon Sep 17 00:00:00 2001 > From: "Ocquidant, Sebastien" <sebastienocquidant@xxxxxxxxx> > Date: Wed, 15 Jun 2016 13:47:35 +0200 > Subject: [PATCH] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing > > In the omap gpmc driver it can be noticed that > GPMC_CONFIG4_OEEXTRADELAY is overwritten by the WEEXTRADELAY value > from the device tree and GPMC_CONFIG4_WEEXTRADELAY is not updated by > the value from the device tree. > > As a consequence, the memory accesses cannot be configured properly > when the extra delay are needed for OE and WE. > > The proposed patch fixes the update of GPMC_CONFIG4_WEEXTRADELAY with > the value from the device tree file and prevents > GPMC_CONFIG4_OEXTRADELAY being overwritten by the WEXTRADELAY value from the device tree. > > Signed-off-by: Ocquidant, Sebastien <sebastienocquidant@xxxxxxxxx> Looks good to me. I'll queue it up for v4.7-rc. As this affects stable kernel let's add Cc: stable@xxxxxxxxxxxxxxx > --- > drivers/memory/omap-gpmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index af4884b..15508df 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -398,7 +398,7 @@ static void gpmc_cs_bool_timings(int cs, const struct gpmc_bool_timings *p) > gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG4, > GPMC_CONFIG4_OEEXTRADELAY, p->oe_extra_delay); > gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG4, > - GPMC_CONFIG4_OEEXTRADELAY, p->we_extra_delay); > + GPMC_CONFIG4_WEEXTRADELAY, p->we_extra_delay); > gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG6, > GPMC_CONFIG6_CYCLE2CYCLESAMECSEN, > p->cycle2cyclesamecsen); > -- cheers, -roger ��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
