Hi Sébastien, On 15/06/16 15:22, SebastienOcquidant@xxxxxxxxx wrote: > Dear M. Quadros, M. Lindgren, > > > > On my new project, I am using Sitara AM335x MPU with Nandflash. > > During my work to configure the gpmc timing to have optimized timing access to this memory I’ve found an issue concerning OEEXTRADELAY and WEEXTRADELAY configuration in gpmc_cs_bool_timings function > > In current version of omap gpmc driver it can be noticed that > > - GPMC_CONFIG4_OEEXTRADELAY is overwritten by WEEXTRADELAY value from device tree file > > - GPMC_CONFIG4_WEEXTRADELAY is not updated by value from device tree > > As a consequence, memory access cannot be configured properly. > > > > I’ve fixed the issue as shown in attached patch. > > This issue has been seen when I did Nandflash timing measurement with my oscilloscope. The patch has been validated during the memory access validation with the oscilloscope. > > > > Let me know if this patch makes sense. > The patch definitely makes sense. Thanks for investigating and following it up upstream. > > > I am working with Linux for 1 year and it is the first I propose a patch. Therefore I am not familiar in submit a patch process. I’ve read some document in Linux Documents directory to propose this patch. > > If I did not follow exactly the process, let me know I will update my submitting according your remarks Just send the patch directly in the e-mail instead of an attachment. You can use git-send-email to help you with that. Some minor comments in your patch. It should mention the subsystem e.g. "memory: omap-gpmc: Fix omap gpmc OEEXTRADELAY and WEEXTRADELAY timing" Patch is missing the commit message where you need to explain in some more detail what the patch is about. -- cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
