Dear, I send again my patch proposal as it was rejected by linux-omap@xxxxxxxxxxxxxxx due to HTML format of the email. Sorry for this inconvenience. Regards, Sébastien OCQUIDANT Hardware Engineer Tel: +33 (0)4 76 00 65 89 Std: +33 (0)4 76 00 65 00 Fax: +33 (0)4 76 00 66 72 sebastienocquidant@xxxxxxxxx www.eaton.com EATON Industrie France Immeuble le Viseo - Bâtiment A 110 rue Blaise Pascal 38334 Montbonnot St Martin - France De : Ocquidant, Sebastien Envoyé : mercredi 15 juin 2016 14:22 À : Roger Quadros; Tony Lindgren Cc : linux-omap@xxxxxxxxxxxxxxx Objet : [PATCH] Fix omap gpmc OEEXTRADELAY and WEEXTRADELAY timing Dear M. Quadros, M. Lindgren, On my new project, I am using Sitara AM335x MPU with Nandflash. During my work to configure the gpmc timing to have optimized timing access to this memory I've found an issue concerning OEEXTRADELAY and WEEXTRADELAY configuration in gpmc_cs_bool_timings function In current version of omap gpmc driver it can be noticed that - GPMC_CONFIG4_OEEXTRADELAY is overwritten by WEEXTRADELAY value from device tree file - GPMC_CONFIG4_WEEXTRADELAY is not updated by value from device tree As a consequence, memory access cannot be configured properly. I've fixed the issue as shown in attached patch. This issue has been seen when I did Nandflash timing measurement with my oscilloscope. The patch has been validated during the memory access validation with the oscilloscope. Let me know if this patch makes sense. I am working with Linux for 1 year and it is the first I propose a patch. Therefore I am not familiar in submit a patch process. I've read some document in Linux Documents directory to propose this patch. If I did not follow exactly the process, let me know I will update my submitting according your remarks Regards, Sébastien OCQUIDANT Hardware Engineer Tel: +33 (0)4 76 00 65 89 sebastienocquidant@xxxxxxxxx www.eaton.com EATON Industrie France Immeuble le Viseo - Bâtiment A 110 rue Blaise Pascal 38334 Montbonnot St Martin - France ----------------------------- Eaton Industries (France) S.A.S ~ Siège social: 110 Rue Blaise Pascal, Immeuble Le Viséo - Bâtiment A Innovallée, 38330, Montbonnot-St.-Martin, France ~ Lieu d'enregistrement au registre du commerce: Grenoble ~ Numéro d'enregistrement: 509 653 176 ~ Capital social souscrit et liberé:€ 16215441 ~ Numéro de TVA: FR47509653176 ----------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html