Ameya Palande wrote:
}
- return status;
+ return ((int_clk_status | fun_clk_status) != DSP_SOK) ? DSP_EFAIL :
+ DSP_SOK;
}
Side note:
Is it possible to rework the code and remove thse insane
DSP_EFAIL and DSP_SOK? Wouldn't it be possible to use
the good practices we have in kernel? Namely,
1. Return 0 on success.
2. Return negative error code on failure?
This is C, not visual basic, after all...
P.S. Ameya, do not take this as a personal attack. The
code is just so ugly and embarrassing, that I cannot stop
flaming :-)
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
