Hi, > -----Original Message----- > From: plasmaroo@xxxxxxxxx [mailto:plasmaroo@xxxxxxxxx] On Behalf Of Tim Yamin > Sent: Wednesday, April 08, 2009 12:31 AM > To: Shah, Hardik > Cc: gregoire@xxxxxxxxxx; tomi.valkeinen@xxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; > beagleboard@xxxxxxxxxxxxxxxx > Subject: Re: YUV rotation support for DSS2 - 2.6.29 [WAS Re: Hello Tomi > Valkeinen, I have some questions about dss2 driver.] > > Hi Hardik / Tomi, > > > [Shah, Hardik] I have also patched the DSS to support the DSS YUV rotation. > Here the rotation type is passed to know the type of rotation required by > driver. I have also modified the FBDEV driver to use this patch. Please find > the both patches. I have tested it on the old master of tomi. Commit id is > 4261fafc4fdc0730b3d4dd83c036d8be09ec8575. I am planning to rebase it on the > latest master soon. I have tested the FBDEV driver with different rotation and > resolution settings. Hi Tim, I have done few changes to your patch. - else if (bytespp == 2) + width >>= 1; Will not work for 32 bit formats like ARGB or RGB24u. Secondly I have fixed lot many check patch warnings/errors in your patch. So please do that before providing patches. Third I have implemented VRFB mirroring also. I have tested YUV, UYVY, RGB24u, RGB16, and ARGB on V4L2 driver with rotation and mirroring with different resolutions on LCD and its working fine. Tim, Will you please test the YUV rotation with frame buffer driver with the attached patch and let us know the result. I have tested RGB rotation and its working fine. Hi Tomi, If YUV rotation with frame buffer passes can you please review the patch and merge it to your latest. Regards, Hardik > > I've merged my changes with your patches and rebased against master, > please find the new patch attached. [Shah, Hardik] Hi Tim, I have modified your DSS2 rotation patch to make it more generic to support YUV as well as ARGB32 and RGB24u formats. > > > [Shah, Hardik] In past I saw setting the FIFO size eliminates this problem. > I have some FIFO setting can you please try this out and let me know the > result. > > FIFO_HIGH_THRES = 0x3FC and GFX_FIFO_LOW_THRES = 0x3BC. This I tried in on > OMAP3. > > Tried this (see attached patch) but does not help -- still getting > these errors as soon as I try to play a video: > > omapdss DISPC error: VID1_FIFO_UNDERFLOW, disabling VID1 > omapdss DISPC error: SYNC_LOST, disabling LCD > > The FIFOs are configured as follows: > > omapdss DISPC: fifo(0) size 1024, low/high old 3008/3071, new 956/1020 > omapdss DISPC: fifo(1) size 1024, low/high old 956/1020, new 956/1020 > > Cheers, > > Tim
Attachment:
0002-DSS2-OMAPFB-Added-support-for-the-YUV-VRFB-rotatio.patch
Description: 0002-DSS2-OMAPFB-Added-support-for-the-YUV-VRFB-rotatio.patch
Attachment:
0001-DSS2-VRFB-rotation-and-mirroring-implemented.patch
Description: 0001-DSS2-VRFB-rotation-and-mirroring-implemented.patch
