Re: [PATCH] ARM: dts: omap3-n900: Specify peripherals LDO regulators initial mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 17.04.2016 03:05, Sebastian Reichel wrote:
Hi Ivo,

On Sat, Apr 16, 2016 at 09:37:23AM +0300, Ivaylo Dimitrov wrote:
Without that, regulators are left in the mode last set by the bootloader or
by the kernel the device was rebooted from. This leads to various problems
like non-working peripherals.

Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx>
---
  arch/arm/boot/dts/omap3-n900.dts | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index b3c26a9..1bb36e2 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -329,6 +329,7 @@
  	regulator-name = "V28";
  	regulator-min-microvolt = <2800000>;
  	regulator-max-microvolt = <2800000>;
+	regulator-initial-mode = <0x0e>;
  	regulator-always-on; /* due to battery cover sensor */
  };

I think this should either get an additional
comment like /* MODE_NORMAL */ or implemented

According to the TRM, this is 'ACTIVE state', but that does not fit in the regulator framework terminology.

using a define and a TWL4030_REGULATOR_MODE_NORMAL
constant to keep the *.dts easily readable.

We already have RES_STATE_ACTIVE defined in linux/i2c/twl.h, is there a way to include that in a dts?

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux