Re: [PATCH] ARM: dts: am335x-baltos-ir5221: fix cpsw_emac0 link type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 18, 2016 at 08:43:22AM +0100, yegorslists@xxxxxxxxxxxxxx wrote:
> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> 
> In Baltos iR5221 cpsw_emac0 is connected directly to the switch IC and
> hence needs to be configured as "fixed-link".
> 
> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>

One nit pick below, but otherwise:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

> ---
>  arch/arm/boot/dts/am335x-baltos-ir5221.dts | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-baltos-ir5221.dts b/arch/arm/boot/dts/am335x-baltos-ir5221.dts
> index ded1eb6..8a0cdda 100644
> --- a/arch/arm/boot/dts/am335x-baltos-ir5221.dts
> +++ b/arch/arm/boot/dts/am335x-baltos-ir5221.dts
> @@ -469,9 +469,12 @@
>  };
>  
>  &cpsw_emac0 {
> -	phy_id = <&davinci_mdio>, <0>;
>  	phy-mode = "rmii";
>  	dual_emac_res_vlan = <1>;
> +	fixed-link {
> +		speed = <100>;
> +		full-duplex;
> +        };

Looks like there is a tab/space problem here.

      Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux