Re: [PATCH] DSPBRIDGE: Fix module build warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Artem Bityutskiy wrote:
Ameya Palande wrote:
diff --git a/drivers/dsp/bridge/wmd/tiomap3430.c b/drivers/dsp/bridge/wmd/tiomap3430.c
index 1fca3e5..b489da1 100644
--- a/drivers/dsp/bridge/wmd/tiomap3430.c
+++ b/drivers/dsp/bridge/wmd/tiomap3430.c
@@ -2034,26 +2034,27 @@ static DSP_STATUS PteSet(struct PgTableAttrs *pt, u32 pa, u32 va,
             if (pfn_valid(__phys_to_pfn(patemp))) {
                 pg = phys_to_page(patemp);
                 get_page(pg);
+                if (page_count(pg) <= 1) {
+                    printk(KERN_EMERG "DSPBRIDGE:MAP  "
+                        "function: COUNT 0 FOR PA "
+                        "0x%x\n", patemp);
+                    printk(KERN_EMERG "Bad page state"
+                        "in process '%s'\n"
+                        "page:%p flags:0x%0*lx "
+                        "mapping:%p mapcount:%d "
+                        "count:%d\n"
+                        "Trying to fix it up, but "
+                        "a reboot is needed\n"
+                        "Backtrace:\n",
+                        current->comm, pg,
+                        (int)(2*sizeof(unsigned long)),
Why do you need this (int) cast? Thiere is a %zd modifyer.
+                        (unsigned long)pg->flags,
What for do you have to cast here?


--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux