Re: [PATCH v5 0/3] ARM: OMAP2+: hwmod: RTC: Add lock and unlock hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 12 Mar 2016, Lokesh Vutla wrote:

> On Friday 11 March 2016 10:17 PM, Paul Walmsley wrote:
> > On Fri, 11 Mar 2016, Lokesh Vutla wrote:
> > 
> >> This series implements lock and unlock functions for RTC and hooks
> >> the same to DRA7 and AMx3xx hwmod.
> >>
> >> Tested RTC functionality on:
> >> DRA7-evm: http://pastebin.ubuntu.com/15346594/
> >> DRA72-evm: http://pastebin.ubuntu.com/15346586/
> >>
> >> Lokesh Vutla (3):
> >>   ARM: hwmod: RTC: Add lock and unlock functions
> >>   ARM: DRA7: RTC: Add lock and unlock functions
> >>   ARM: AMx3xx: RTC: Add lock and unlock functions
> >
> > Earlier you wrote that you were going to look into resending this patch 
> > set without omap_rtc_wait_not_busy().  Were you able to determine 
> > dispositively whether that was needed?
> 
> So, I experimented without omap_rtc_wait_not_busy, but sysconfig is not
> being updated properly and also gives a L3 error during boot.

OK great.  Please note this in the patch description for #1 that this is 
needed for non-TC registers, and that you've tested it to confirm.  
Please also address my earlier comment about '15-?s' in the kerneldoc 
comments.  Then resend the updated #1.  #2 and #3 look ready to go; you 
don't need to repost those if you'd prefer not to.

- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux