Hi, On Tue, Mar 08, 2016 at 08:39:08PM +0200, Aaro Koskinen wrote: > On Tue, Mar 08, 2016 at 05:39:32PM +0100, Sebastian Reichel wrote: > > This series adds support for the Nokia N950 display. > > Since the panel is using DSI command mode, it involves > > adding support for manually updated displays to > > omapdrm. > > Works OK, but the picture seems to be upside down? vertical, upside down is the native panel orientation. > Also shouldn't the default orientation be landscape? The N950 vendor kernel contains some code adding DSI rotation support with half-frame update mechnism to avoid tearing. It's quite complex and as far as I understand it also error-prone. Tomi knows more about that. I have a simpler patch without the half-frame update stuff, which works fine for me. I didn't notice any tearing, but I haven't done any really fast image updating. Also omapdrm has rotation support using the DSS hardware, which also seems to work ok. I'm still checking out what method is most suitable for mainline. But yeah, we probably want to change the default rotation. Especially since touchscreen should have the same default rotation as the screen. (TS is horizontal, correct orientation for keyboard usage) I will have a look at the (default-)rotation when basic panel support has been ACKed. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
