Hello Tomi, On Tue, Feb 16, 2016 at 03:00:00PM +0200, Tomi Valkeinen wrote: > On 20/12/15 13:13, Uwe Kleine-König wrote: > > @@ -223,6 +232,10 @@ static int panel_dpi_probe_of(struct platform_device *pdev) > > if (IS_ERR(gpio)) > > return PTR_ERR(gpio); > > > > + ddata->vcc_supply = devm_regulator_get(&pdev->dev, "vcc"); > > + if (IS_ERR(ddata->vcc_supply)) > > + return PTR_ERR(ddata->vcc_supply); > > devm_regulator_get_optional()? That would make the specification of a vcc supply obligatory IIUC. (Yes, the semantic difference between regulator_get vs. regulator_get_optional is reversed when comparing to gpio_get vs. gpio_get_optional.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
