Hi, Le mardi 29 décembre 2015 à 15:55 -0600, Rob Herring a écrit : > On Tue, Dec 29, 2015 at 3:26 PM, Paul Kocialkowski <contact@xxxxxxxx> wrote: > > Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit : > >> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > >> > LP872x regulators are made active via the EN pin, which might be hooked to a > >> > GPIO. This adds support for driving the GPIO high when the driver is in use. > >> > > >> > Signed-off-by: Paul Kocialkowski <contact@xxxxxxxx> > >> > --- > >> > .../devicetree/bindings/regulator/lp872x.txt | 1 + > >> > drivers/regulator/lp872x.c | 33 ++++++++++++++++++++-- > >> > include/linux/regulator/lp872x.h | 2 ++ > >> > 3 files changed, 33 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt > >> > index 7818318..0559c25 100644 > >> > --- a/Documentation/devicetree/bindings/regulator/lp872x.txt > >> > +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt > >> > @@ -28,6 +28,7 @@ Optional properties: > >> > - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices. > >> > - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2. > >> > - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH. > >> > + - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices. > >> > >> Should be "-gpios" instead of "-gpio". Thanks for the review Rob, I have just submitted v2 with those suggestions integrated. > > Care to comment why? There is only one GPIO that can be used here, since > > there is only one single EN pin. I thought this matched what is done > > already with "ti,dvs-gpio". > > To be consistent. We use "clocks" and "interrupts" always whether one > or more for example. > > -gpio is documented as deprecated now. > > Rob
Attachment:
signature.asc
Description: This is a digitally signed message part
