Re: [PATCH 1/2] ARM: ATAGS: move save_atags() to include/asm arch/arm/include/asm/setup.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Sebastian Reichel <sre@xxxxxxxxxx> [160128 08:43]:
> Hi,
> 
> On Thu, Jan 28, 2016 at 08:17:24AM -0800, Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@xxxxxxxxx> [160128 00:34]:
> > > On Thursday 28 January 2016 01:05:53 Sebastian Reichel wrote:
> > > > IIRC this was the last blocker for removing n900 legacy code?
> > > 
> > > No! I know at least two missing-feature regressions in DT booted
> > > kernel:
> > > 
> > > * slot name in sysfs for omap mmc devices
> > 
> > Can't you do this already by passing platform_data in addition to
> > dts using pdata-quirks.c?
> > 
> > Then when we have a generic binding for this we can move to use
> > that.
> 
> I guess the driver must be modified to check and parse platform_data
> if initalised via DT, but I think this could be done in time for
> v4.6.

Yes for sure. There's nothing stopping having both platform_data
and data from dts available in driver probe. Coming up with a
generic binding then can be done as a follow-up project.

> > > * missing DT support for ir-rx51 driver
> > 
> > I believe this still works the same as ever with platform_data if
> > you completely disable multiarch. However, that's not a good
> > solution, it's best to update it to use the generic
> > drivers/pwm/pwm-omap-dmtimer.c.
> >
> > I can take a look at this one no problem unless somebody else
> > is already working on it.
> 
> I had a look at it some time ago. IIRC one can simply replace the
> <plat/clock.h> with <linux/clk.h>. The dmtimer part requires more
> work, since it uses two dmtimers: One in PWM mode (the output of
> this one is connected to the IR led). This one could probably be
> converted to pwm-omap-dmtimer. But it also uses a second one for
> calculating the pulse length. I have not yet tried it, but I guess
> converting is not really trivial.

OK. I'll take a look. We may get away with hrtimer for the pulse
length calculation.

> OTOH it's also broken for quite some time (3.8!) on multiplatform,
> so I wonder if this is really a blocker. Has this been compiled
> by anybody on an unpatches mainline kernel since then? Maybe it
> could be fixed after switching to DT only?

Right.. I doubt anybody has been using the non-multiplatform
configuration for ages on omaps.

Regards,

Tony


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux