Paul, > -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Tuesday, March 24, 2009 2:58 PM > To: Kevin Hilman > Cc: Gupta, Ramesh; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/1] Export notifier register functions > for kernel module building > > Hello Kevin, Ramesh, > > On Thu, 12 Feb 2009, Kevin Hilman wrote: > > > "Gupta, Ramesh" <grgupta@xxxxxx> writes: > > > > > This Patch exports symbols > clk_notifier_register/unregister function > > > for other kernel modules usage. > > > > > > Signed-off-by: Ramesh Gupta G <grgupta@xxxxxx> > > > > Thanks, pushed to PM branch. > > As an aside, this patch should be reverted. DSPBridge and > other drivers needing clock notifiers should pass function pointers to > clk_notifier_{register,unregister}() in their struct > platform_data, rather than exporting those symbols. This > will keep the drivers platform-agnostic, since system-wide > clock notifiers are not yet upstream. I agree on this, I think the latest patch set from Rajendra Naik([1]) removes the EXPORT_SYMBOL for the clk notifier functions. Ref[1]: http://marc.info/?l=linux-omap&m=123755561914202&w=2 Ref[2]: http://marc.info/?l=linux-omap&m=123755561914205&w=2 We will send a patch to dspbridge sources to adopt these changes. Please let me know your comments. Thanks Ramesh Gupta G-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
