Re: [PATCH] OMAP3 clock: Access only available clock bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On Sat, Mar 21, 2009 at 6:48 AM, Paul Walmsley <paul@xxxxxxxxx> wrote:
> Hello Kyuwon,
>
> On Fri, 20 Mar 2009, Kim Kyuwon wrote:
>
>> I found a problem on PM Branch with OMAP3430 ES3.1 Board when enabling
>> OMAP_RESET_CLOCKS feature.
>> In clk_disable_unsed() function, as soon as sad2d_ick is disabled,
>> prcm interrupt is generated and its handler can't exit loop at next
>> statement!
>>
>> while (prm_read_mod_reg(OCP_MOD, OMAP2_PRM_IRQSTATUS_MPU_OFFSET));
>
> We encountered a similar problem a few months ago.  The problem is
> probably the pad mux settings on the d2d_mstdby and d2d_swakeup pads.
> These are usually configured by the bootloader.  My recollection is that
> they should be pulled up, but I don't recall for sure.  Yes, we should
> have a patch in the PM branch to at least detect whether these pads are
> configured incorrectly...

Thank you for letting me know the better solution. I confirmed that
this problem can be fixed by configuring the d2d_mstdby and
d2d_swakeup pads. (As you said, swakeup -> pulled down & mstdby ->
pulled up.)

>> I also found that sad2d_ick is available only OMAP3430 ES1. I fixed
>> this problem with below patch.
>
> Thanks for your patch, but, sad2d_ick is indeed present on ES2+. TI
> removed the documenation from the main TRM and moved it to the "OMAP34xx
> Stacked Mode Addendum" (SWCU048).  Ill-advised, in my opinion!
>

I have only the "OMAP34xx ES3.0 Stacked Mode Addendum" and I can see
EN_SAD2D is available in this document. ES3.1 is maybe same.
I think this patch is not needed anymore. Thank you so much for your help!

Regards,
Kyuwon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux