On Friday 20 March 2009 03:24:49 Aguirre Rodriguez, Sergio Alberto wrote: > Hi Hans, > > I did a quick analysis of the subdev, and noticed that some video ioctls > for the subdevices aren't there... > > [gs]_crop > [gs]_parm > enum_frameintervals > enum_framesizes > enum_fmt_cap > > I noticed this because we currently use them for a "best sensor output" > selection before sending the image to the OMAP3 ISP. > > Any particular reason why these aren't there? Because no other i2c drivers needed them until now. I try to avoid adding code that nobody is using. Note that gs_parm was just added. And in video_ops there is already an enum_fmt. Feel free to add crop and the enum_frame* ops. If you mail me a patch, then I'll commit it. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html