On 19/10/15 19:01, Tony Lindgren wrote:
> * Roger Quadros <rogerq@xxxxxx> [151014 03:48]:
>> Let's keep the SSI ports disabled in the omap3.dtsi to avoid
>> getting the following noise on the console for boards that don't
>> use the SSI ports.
>>
>> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"
>>
>> As omap3-n900 uses one SSI port, mark it enabled there.
>
> This is the wrong way around.. The SSI ports are there on all omap3 SoCs,
> we do want to have the struct device created for them. It's best to have
> the driver probe and then idle SSI and bail out. Marking something with
> status = "disabled" should be only used if you really want to avoid kernel
> touching the device at all, for example, if something is managed from
> the start by a copropcessor.
Agreed. Please ignore this patch.
cheers,
-roger
>
>
>> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
>> ---
>> arch/arm/boot/dts/omap3-n900.dts | 1 +
>> arch/arm/boot/dts/omap3.dtsi | 2 ++
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
>> index 5f5e0f3..bdb72fb 100644
>> --- a/arch/arm/boot/dts/omap3-n900.dts
>> +++ b/arch/arm/boot/dts/omap3-n900.dts
>> @@ -949,6 +949,7 @@
>> };
>>
>> &ssi_port1 {
>> + status = "ok";
>> pinctrl-names = "default";
>> pinctrl-0 = <&ssi_pins>;
>>
>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>> index 8a2b253..25b0b37 100644
>> --- a/arch/arm/boot/dts/omap3.dtsi
>> +++ b/arch/arm/boot/dts/omap3.dtsi
>> @@ -815,6 +815,7 @@
>> interrupt-parent = <&intc>;
>> interrupts = <67>,
>> <68>;
>> + status = "disabled";
>> };
>>
>> ssi_port2: ssi-port@4805b000 {
>> @@ -828,6 +829,7 @@
>> interrupt-parent = <&intc>;
>> interrupts = <69>,
>> <70>;
>> + status = "disabled";
>> };
>> };
>> };
>> --
>> 2.1.4
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
