"Nayak, Rajendra" <rnayak@xxxxxx> writes: > Hi, > > This series fixes a set of defects/issues in Smartreflex driver. SR autocompensation is now > functional and is validated with these patches on a ES3.1 based SDP with the > N values in Efuse. > Patches apply and are validated on the latest pm branch (2.6.28). > Hi Rajendra, Thanks for this series of SR fixes. I send a couple very minor comments to a couple of the patches. Also, this series does not apply cleanly to pm-2.6.28, I'm not sure why. Applying manually with 'patch' allows them to apply with "fuzz" suggesting that they were not generated against the current tree. Also, while you are in there cleaing up, could you add one more patch which converts the printk(KERN_* ...) into pr_debug, pr_err, pr_info, etc. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html