> You tell me :) > > I just moved code around. I don't truly understand what it's doing. > Maybe the read is needed for some kind of sync? > > I've removed the tlb flush all completely and I didn't notice any > problems, is it really needed? > -- Ignore my previous comment. I think temp is used for other purpose in the same function. I thought temp was used by only the part of the code section that you stripped out. Thank you, Best regards, Hari > -----Original Message----- > From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] > Sent: Wednesday, March 18, 2009 8:30 AM > To: Kanigeri, Hari > Cc: linux-omap@xxxxxxxxxxxxxxx; Hiroshi DOYU; Ameya Palande; Guzman Lugo, > Fernando; Felipe Contreras > Subject: Re: [PATCH B 1/3] tidspbridge: don't flood the mailbox on > MemUnMap > > On Wed, Mar 18, 2009 at 3:06 PM, Kanigeri, Hari <h-kanigeri2@xxxxxx> > wrote: > > Felipe, > > > >> Check the hardware state of the DSP before sending the command to wake > >> it up thus avoiding to flood the mailbox unnecessarily. > >> > > -- So this check was missing in Unmap part. Good catch. > > > > > >> - u32 temp = 0; > >> - struct CFG_HOSTRES resources; > >> u32 *pPhysAddrPageTbl = NULL; > >> struct vm_area_struct *vma; > >> struct mm_struct *mm = current->mm; > >> + u32 temp = 0; > >> > > > > -- Is temp variable needed ? > > You tell me :) > > I just moved code around. I don't truly understand what it's doing. > Maybe the read is needed for some kind of sync? > > I've removed the tlb flush all completely and I didn't notice any > problems, is it really needed? > > -- > Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
