Re: [RFC] AM35xx glue code for M-USB driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

thank you for your reply.

On 07.10.2015 15:59, Felipe Balbi wrote:
> 
> Hi,
> 
> (please sure you also Cc linux-usb@xxxxxxxxxxxxxxx for MUSB patches)
> 
> Rolf Peukert <rolf.peukert@xxxxxxx> writes:
[...]
>> b) The M-USB port on our board is wired as host only. If a device is
>> unplugged, the driver normally goes into some idle state and waits for
>> an ID signal change. But on our board that never happens.
> 
> did you route ID pin anywhere ? I hope you tied it to ground.

I think so. I'll double-check that.

[...]
>> +	/* Set defaults */
>> +	config->num_eps = 16;
>> +	config->ram_bits = 12;
>> +	config->multipoint = true;
> 
> all of these are board-specific.
> 
>> +
>> +	bdata->interface_type = MUSB_INTERFACE_UTMI;
>> +	bdata->mode = MUSB_OTG;
>> +	bdata->power = 500;
>> +	bdata->extvbus = 1;
> 
> so are these.

The AM3517/05 has an internal phy, so some of these are predetermined.
You're right about mode and power.

[...]
>> +	phy_clk = clk_get(&pdev->dev, "hsotgusb_fck");
> 
> why did you change the clock name ? That shouldn't be necessary.

I did get "failed to get PHY clock" and "failed to get clock" messages.

I'll do some more testing and see if I can get by with less changes.

Best regards,
Rolf

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux