"Premi, Sanjeev" <premi@xxxxxx> writes:
[...]
>> > > +static int _cpuidle_allow_idle(struct powerdomain *pwrdm,
>> > > + struct clockdomain *clkdm)
>> > > +{
>> > > + omap2_clkdm_allow_idle(clkdm);
>> > > +}
>> > > +
>> > > +static int _cpuidle_deny_idle(struct powerdomain *pwrdm,
>> > > + struct clockdomain *clkdm)
>> > > +{
>> > > + omap2_clkdm_deny_idle(clkdm);
>> > > +}
>> > > +
>>
>> These functions don't return any value. Even the functions
>> omap2_clkdm_allow_idle() and omap2_clkdm_deny_idle() are void.
>>
>> So, the return type should be changed to void. Else complier
>> would throw warnings like:
>>
>> warning: no return statement in function returning non-void
>>
>> ~sanjeev
>>
>
> [sp] I commented on the patch without trying myself.
> The return type "int" is necessary for calls to functions
> pwrdm_for_each_clkdm().
>
> So, real solution would be to return with a value.
>
> @@ -70,12 +70,14 @@ static int _cpuidle_allow_idle(struct powerdomain *pwrdm,
> struct clockdomain *clkdm) {
> omap2_clkdm_allow_idle(clkdm);
> + return 0;
> }
>
> static int _cpuidle_deny_idle(struct powerdomain *pwrdm,
> struct clockdomain *clkdm)
> {
> omap2_clkdm_deny_idle(clkdm);
> + return 0;
> }
>
Thanks, I've merged this change into teh original patch and re-pushed
the PM branch.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
