Re: [PATCH] phy: add dm816x dependency on USB_PHY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnd,

On Tuesday 19 May 2015 06:32 PM, Arnd Bergmann wrote:
The newly added phy-dm816x-usb driver depends on the
usb phy API and fails to link if that is disabled:

drivers/built-in.o: In function `dm816x_usb_phy_remove':
:(.text+0x3a28): undefined reference to `usb_remove_phy'
drivers/built-in.o: In function `dm816x_usb_phy_probe':
:(.text+0x3c18): undefined reference to `usb_add_phy_dev'

A patch to fix this has already been queued in the fixes branch
https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit/?h=fixes&id=7f7a4d306ff87502dc26860f54e798693cf9b1e1

Thanks
Kishon

This adds an explicit dependency in Kconfig to avoid the
build error in randconfig tests.

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Fixes: 609adde838f4 ("phy: Add a driver for dm816x USB PHY")

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index fceac96c2a31..1b5c235562c9 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -37,7 +37,7 @@ config ARMADA375_USBCLUSTER_PHY

  config PHY_DM816X_USB
  	tristate "TI dm816x USB PHY driver"
-	depends on ARCH_OMAP2PLUS
+	depends on ARCH_OMAP2PLUS && USB_PHY
  	select GENERIC_PHY
  	help
  	  Enable this for dm816x USB to work.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux