> -----Original Message----- > From: Tuukka.O Toivonen [mailto:tuukka.o.toivonen@xxxxxxxxx] > Sent: Tuesday, March 10, 2009 9:30 AM > To: Menon, Nishanth > Cc: Aguirre Rodriguez, Sergio Alberto; Alexey Klimov; linux- > media@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; Sakari Ailus; Doyu > Hiroshi (Nokia-D/Helsinki); DongSoo(Nathaniel) Kim; MiaoStanley; Nagalla, > Hari; Hiremath, Vaibhav; Lakhani, Amish > Subject: Re: [PATCH 3/5] OV3640: Add driver > > On Monday 09 March 2009 23:29:27 ext Menon, Nishanth wrote: > > Further, we have multiple sensors following CCI[1] - why not have a > driver > > for the same, it will simplify the entire process - ov3640, mt9p012 both > > follow the spec at least.. dependency would be sensor -> cci dev->i2c > > framework. > > Sakari has written smiaregs.c pretty much exactly for this > purpose. You should check it out. Yes, smiaregs probably has a few more functionality than pure reg access APIs. Comparing CCI as defined in CCP2 spec and CSI2 spec, CCP2 spec says - register addressing could be 8 or 16, but the data size is 8 bit. In the case of CSI2, the data size could be 8, 16, 32 or 64 bytes.. we could say that CSI2's CCI is kind of a superset of CCI as defined by CCP2 spec. Might be a good idea to split the cci access out of smia_regs.c and make it a little more generic so that devices not caring for smia register set organization but using MIPI type access could also use it. Regards, Nishanth Menon Ref: [1] MIPI CSI2 revision 1.0 [2] SMIA CCP2 spec rev 1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html