On Friday 27 February 2015 07:38:09 Tony Lindgren wrote: > * Aaro Koskinen <aaro.koskinen@xxxxxx> [150226 15:06]: > > Hi, > > > > On Thu, Feb 26, 2015 at 11:19:50PM +0100, Pavel Machek wrote: > > > Ok, it seems that new config dependencies broke my kconfig. These will > > > not be enabled if you just to make oldconfig; you want to make sure > > > they are on. > > > > > > OMAP2430 and onwards (USB_MUSB_OMAP2PLUS) [N/m/y] (NEW) > > > TWL4030 USB Transceiver Driver (TWL4030_USB) [N/m/y/?] (NEW) > > > > Yes, also other users have reported "USB breakage" with 4.0-rc1 on N900 > > etc caused by this. > > > > Commit fbba7db3990cb707ff91cd6507d53a0a730afe97 (usb: musb: > > add omap-control dependency) changed USB_MUSB_OMAP2PLUS to depend > > on OMAP_CONTROL_PHY but that seems to be wrong at least for OMAP3. > > omap_control_phy.h provides dummy functions when it's not enabled. > > So there should be no dependency. The problem I fixed was a link error when USB_MUSB_OMAP2PLUS is built-in but OMAP_CONTROL_PHY is a loadable module. > I guess the solution would be to make drivers/phy handle whatever > omap_control_usb_set_mode is doing in a generic way. I'm very sorry about the breakage in a patch that is marked for backports. Please accept my apology and the workaround patch in the follow-up mail. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
