Hi Rui,
On 02/09/2015 05:01 PM, Nishanth Menon wrote:
> On 16:55-20150206, grygorii.strashko@xxxxxxxxxx wrote:
>> From: Grygorii Strashko <Grygorii.Strashko@xxxxxxxxxx>
>>
>> Fix following build warning if CONFIG_PM_SLEEP is not set:
>>
>> drivers/thermal/ti-soc-thermal/ti-bandgap.c:1478:12: warning: 'ti_bandgap_suspend' defined but not used [-Wunused-function]
>> static int ti_bandgap_suspend(struct device *dev)
>> ^
>> drivers/thermal/ti-soc-thermal/ti-bandgap.c:1492:12: warning: 'ti_bandgap_resume' defined but not used [-Wunused-function]
>> static int ti_bandgap_resume(struct device *dev)
>> ^
>> Signed-off-by: Grygorii Strashko <Grygorii.Strashko@xxxxxxxxxx>
>> ---
>> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
>> index 74c0e34..5d46660 100644
>> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
>> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
>> @@ -1402,7 +1402,7 @@ int ti_bandgap_remove(struct platform_device *pdev)
>> return 0;
>> }
>>
>> -#ifdef CONFIG_PM
>> +#ifdef CONFIG_PM_SLEEP
>> static int ti_bandgap_save_ctxt(struct ti_bandgap *bgp)
>> {
>> int i;
>> --
>> 1.9.1
>>
>
> Suggest aligning with Paul as well:
> https://patchwork.kernel.org/patch/5795391/
^Paul Walmsley wrote: Oh, nothing to be confused by, I just missed the
earlier patch. I withdraw mine.
>
> Otherwise:
> Acked-by: Nishanth Menon <nm@xxxxxx>
>
It looks like this patch is missed in 4.0-rc1, so could it be merged
during rc cycle or you'd like me to resend it?
(I've rechecked - it can be applied on top of Linux 4.0-rc1 without any issues)
--
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
