* Roger Quadros <rogerq@xxxxxx> [150126 01:38]: > On 24/01/15 22:28, Semen Protsenko wrote: > > Some GPMC_CONFIG7 register bits marked as "RESERVED", means they > > shouldn't be overwritten. A typical approach to handle such bits called > > "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf() > > utilizes RMW technique, but implemented incorrectly. Due to obvious typo > > in code read register value is being rewritten by another value, which > > leads to loss of read RESERVED bits. This patch fixes this. > > > > While at it, replace magic numbers with named constants to improve code > > readability. > > > > Signed-off-by: Semen Protsenko <semen.protsenko@xxxxxxxxxxxxxxx> > > This is much nicer. > > Acked-by: Roger Quadros <rogerq@xxxxxx> Roger will queue this so: Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
