On Tue, Jan 13, 2015 at 01:48:24PM -0600, Tom Lendacky wrote: > On 01/13/2015 01:29 PM, Tony Lindgren wrote: > >We only use clk_get() to get the frequency, the rest is done by > >the runtime PM calls. Let's free the clock too. > > > >Cc: Brian Hutchinson <b.hutchman@xxxxxxxxx> > >Cc: Felipe Balbi <balbi@xxxxxx> > >Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > >--- > > drivers/net/ethernet/ti/davinci_emac.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c > >index deb43b3..e9efc74 100644 > >--- a/drivers/net/ethernet/ti/davinci_emac.c > >+++ b/drivers/net/ethernet/ti/davinci_emac.c > >@@ -1881,6 +1881,7 @@ static int davinci_emac_probe(struct platform_device *pdev) > > return -EBUSY; > > } > > emac_bus_frequency = clk_get_rate(emac_clk); > >+ clk_put(emac_clk); > > The devm_clk_get call is used to get the clock so either a devm_clk_put > needs to be used here or just let the devm_ call do its thing and > automatically do the put when the module is unloaded. instead, if you really don't need the clock for anything other than getting its rate, why don't you just remove devm_ prefix from clk_get()? -- balbi
Attachment:
signature.asc
Description: Digital signature
