On 2015-01-08 15:06, Nishanth Menon wrote:
On 17:42-20150107, Marc Zyngier wrote:
Tegra's LIC (Legacy Interrupt Controller) has been so far only
supported as a weird extension of the GIC, which is not exactly
pretty.
The stacked irq domain framework fits this pretty well, and allows
the LIC code to be turned into a standalone irqchip. In the process,
make the driver DT aware, something that was sorely missing from
the mach-tegra implementation.
Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
---
Saw a few checkpatch warnings as below: all of them seem minors.
@@ -0,0 +1,35 @@
+WARNING: added, moved or deleted file(s), does MAINTAINERS need
updating?
I'll leave to the Tegra maintainers to update this file it they want
to.
+#36:
+new file mode 100644
+WARNING: line over 80 characters
+#169: FILE: drivers/irqchip/irq-tegra.c:129:
++ tegra_ictlr_info->cpu_ier[i] = readl_relaxed(ictlr +
ICTLR_CPU_IER);
As a matter of principle, I ignore what checkpatch says about the
length of lines of code. I trust my eyes more than the tool.
[...]
+WARNING: Missing a blank line after declarations
+#196: FILE: drivers/irqchip/irq-tegra.c:156:
++ void __iomem *ictlr = tegra_ictlr_info->ictlr_reg_base[i];
++ writel_relaxed(tegra_ictlr_info->cpu_iep[i],
Done.
+WARNING: line over 80 characters
+#284: FILE: drivers/irqchip/irq-tegra.c:244:
++ return irq_domain_alloc_irqs_parent(domain, virq, nr_irqs,
&parent_args);
+CHECK: Please don't use multiple blank lines
+#287: FILE: drivers/irqchip/irq-tegra.c:247:
++
++
+WARNING: Missing a blank line after declarations
+#296: FILE: drivers/irqchip/irq-tegra.c:256:
++ struct irq_data *d = irq_domain_get_irq_data(domain, virq + i);
++ irq_domain_reset_irq_data(d);
`
Thanks,
M.
--
Fast, cheap, reliable. Pick two.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
