* Dmitry Lifshitz <lifshitz@xxxxxxxxxxxxxx> [141229 23:42]: > On 12/29/2014 03:06 PM, Roger Quadros wrote: > >On 28/12/14 16:30, Dmitry Lifshitz wrote: > >>--- a/arch/arm/boot/dts/omap3-cm-t3x30.dtsi > >>+++ b/arch/arm/boot/dts/omap3-cm-t3x30.dtsi > >>@@ -50,7 +50,8 @@ > >> #include "omap-gpmc-smsc911x.dtsi" > >> > >> &gpmc { > >>- ranges = <5 0 0x2c000000 0x01000000>; > >>+ ranges = <5 0 0x2c000000 0x01000000>, /* CM-T3x30 SMSC9x Eth */ > >>+ <0 0 0x00000000 0x01000000>; /* CM-T3x NAND */ > > > >Isn't this ranges property redundant as it will anyways be overridden by the board specific dts? > > > > The ranges are specified here (and other files below) by design. > > We built a tree like structure to organize DT files - > d234e4239 "ARM: dts: sbc-t3x: refactor DT support" > > It allows to inherit/override properties common for different boards. > > Our customers do not have to deal with a correct GPMC ranges settings, once > they base on omap3-cm-t3x.dts core module DT file (in case they do not > connect additional device to the bus). > > This is the point of Igor's comment to the previous patch version. Roger, do you still have pending issues with this patch? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html