* Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [150106 10:08]: > On Tue, Jan 06, 2015 at 10:51:33AM -0600, Felipe Balbi wrote: > > + /* > > + * FIXME legacy OMAP DMA driver sitting under arch/arm/plat-omap/dma.c > > + * depends is still not ready for linear IRQ domains; because of that > > + * we need to temporarily "blacklist" OMAP2 and OMAP3 devices from using > > + * linear IRQ Domain until that driver is finally fixed. > > "finally fixed" or finally killed off like it really needs to be, once > all users of it are killed. > > We've been trying to do this for, what, three years now... I finally > pushed a WARN_ON() into that code to make it obvious to anyone who > uses omap_request_dma() that they really need to update their code. > > Here's the list of references to that symbol which *still* need to be > fixed so that we can kill the legacy DMA driver: > > drivers/media/platform/omap/omap_vout_vrfb.c: ret = omap_request_dma(vout->vrfb_dma_tx.dev_id, "VRFB DMA TX", > drivers/media/platform/omap3isp/isphist.c: ret = omap_request_dma(OMAP24XX_DMA_NO_DEVICE, "DMA_ISP_HIST", > drivers/media/platform/soc_camera/omap1_camera.c: err = omap_request_dma(OMAP_DMA_CAMERA_IF_RX, DRIVER_NAME, > drivers/mtd/onenand/omap2.c: r = omap_request_dma(0, pdev->dev.driver->name, AFAIK we should just remove DMA support from the drivers above. Nobody seems to be interested in doing anything about them. > drivers/usb/gadget/udc/omap_udc.c: status = omap_request_dma(dma_channel, > drivers/usb/gadget/udc/omap_udc.c: status = omap_request_dma(dma_channel, OK so Aaro picked this one. > drivers/usb/musb/tusb6010_omap.c: ret = omap_request_dma(chdat->sync_dev, dev_name, > drivers/usb/musb/tusb6010_omap.c: ret = omap_request_dma(tusb_dma->sync_dev, "TUSB shared", I'll update this one. FYI, I already have some work-in-progress MUSB DMA patches that allow building in all the MUSB DMA glue layers. I just need to finish that series for v3.20: https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=musb-dma-2014-11-25-v2 So converting tusb6010 over to the dmaengine API would be the next logical step after that series. Probably not going to happen before v3.21 though.. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
