Re: [PATCH] cleanup ti-soc-thermal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/03/2015 12:51 PM, Pavel Machek wrote:
On Sat 2015-01-03 11:48:04, Nishanth Menon wrote:
On 12:19-20150103, Pavel Machek wrote:
Simplify code by removing goto's where they point to simple return.

Avoid confusing |= on error values.

Please split these up into chunks of related changes. there is white
space and quiet a few other changes all mixed in.

Do you believe that the patch is too big to be understood? I don't
think it is.

It is four screens, and it is pretty obvious it does not change any
code.

It basic patch generation stuff - where you are being nice to the reviewer. When you are doing functional changes, at least drop out or at the very least mention that there are white space changes in your patch submission.

I dont care too much to review stuff where I have to look at multiple changes in a single patch - trivial or not. Sorry.. just a waste of my time.

--
Regards,
Nishanth Menon

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux