Hi!
On Thu 2014-12-18 20:31:53, Pavel Machek wrote:
> Hi!
>
> > > + h4p_simple_send_frame(info, skb);
> > > +
> > > + if (!wait_for_completion_interruptible_timeout(&info->init_completion,
> > > + msecs_to_jiffies(1000))) {
> > > + printk("h4p: negotiation did not return\n");
> >
> > Memory leak in the error case
>
> And memory leak in the normal case, too, no? Fixed.
Actually, no, h4p_simple_send_frame passes skb to network stack, and
it should free it as neccessary.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
