On Thursday 27 November 2014 00:14:36 Tony Lindgren wrote: > * Pali Rohár <pali.rohar@xxxxxxxxx> [141126 15:03]: > > On Wednesday 26 November 2014 21:08:06 Tony Lindgren wrote: > > > > With your patch I'm getting: > > > > Hardware : Nokia RX-51 board > > > > So patch is good. > > Is that a Tested-by: then? :) > Yes for Hardware line you can add my: Tested-by: Pali Rohár <pali.rohar@xxxxxxxxx> > > > > Revision comes from bootloader (via ATAG) and it is HW > > > > revision of N900 device. It cannot be hardcoded into > > > > kernel or DTS as it it depends on HW. > > > > > > Well for the "Revision" line problem, we could pass the > > > revision in cmdline or .dts if not passed in the legacy > > > ATAGs. It sounds like were just not copying it to > > > system_rev for DT based booting? Maybe it's just some > > > missing CONFIG_ATAG option that needs to be enabled? > > > > Yes it looks like DT code does not read Revision ATAG... I > > tried to enable everything but always same problem... > > Maybe check if it shows up properly in /proc/atags or whatever > the interface for it was? > With enabled CONFIG_ARM_APPENDED_DTB=y file /proc/atags is missing. > The build_tag_list() should parse ATAG_REVISION and then > parse_tag_revision() should copy it to system_rev. Maybe try > adding some printks to see if those functions get called? > > Regards, > > Tony Now I see... Problem is that build_tag_list() is called from convert_to_tag_list() which is called from setup_machine_tags() which is called from setup_arch() only if setup_machine_fdt() call fails. And it fails for *non* DT boot. You can check this chain too. -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.
