Hi Tomi, thanks for the ping. On Fri, 14 Nov 2014, Tomi Valkeinen wrote: > On 09/10/14 17:03, Tomi Valkeinen wrote: > > This is an RFC to fix the issues with boot time DSS hwmod setup. > > > > There was an earlier series sent by Archit here: > > > > http://www.spinics.net/lists/linux-omap/msg107700.html > > > > This series takes different approach, and just tries to fix the issue at setup > > time by making sure the DSS core hwmod is enabled when a DSS submodule hwmod is > > being setup. > > > > Quickly tested on OMAP4 Panda and OMAP5 uEVM. > > > > Tomi > > > > Tomi Valkeinen (6): > > ARM: OMAP2+: hwmod: add parent_hwmod support > > ARM: OMAP5: hwmod: set DSS submodule parent hwmods > > ARM: OMAP4: hwmod: set DSS submodule parent hwmods > > ARM: OMAP4: hwmod: use MODULEMODE properly > > ARM: OMAP4: fix RFBI iclk > > ARM: dts: omap4.dtsi: remove dss_fck > > > > arch/arm/boot/dts/omap4.dtsi | 2 +- > > arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 -------- > > arch/arm/mach-omap2/omap_hwmod.c | 22 ++++++++++++++++++++++ > > arch/arm/mach-omap2/omap_hwmod.h | 1 + > > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 25 ++++++++++++++++--------- > > arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 5 +++++ > > 6 files changed, 45 insertions(+), 18 deletions(-) > > > > Ping. Would this series be acceptable? Yes, it looks good for the short term, and definitely moves us closer to where we should be. Queued with Archit's Reviewed-by:, with some extra documentation added to the first patch. If you have a spare moment, could you take a quick look at it? It should not result in any functional changes. In theory, that .parent_hwmod information should come from the omap_hwmod_ocp_if data. But as you know, unfortunately due to some limitations in the hwmod code, we don't handle IP blocks with multiple interconnect parents very well right now. Ultimately we should only have one "OCP" interface between each of the DSS IP blocks. But for that to work, the physical address code needs to be overhauled, and the data should be specified as offsets rather than absolute addresses. One of these days. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
